Skip to content

remove unneccessaries from pch to reduce size and fix storage quote i… #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

burtonrodman
Copy link
Contributor

Summary

The Azure DevOps hosted build agents are documented to be limited to 10GB (empirically ~13GB). With my project and multiple community module PCH files building to between 100MB to 1.2GB, that space goes fast. This PR reduces the PCH for datetimepicker from 102MB down to 13MB.

Test Plan

  • Ensure the code builds and the PCH file size is reduced.
  • Include updated module in production project, publish to update website via CI/CD build, ensure build completes without error
  • Update app on Surface Tablet and ensure all behaviors continue to work as expected.

What's required for testing (prerequisites)?

  • Windows development environment

What are the steps to reproduce (after prerequisites)?

  • build module and notice pch.pch is ~102MB (for x86)

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak requested a review from rectified95 April 27, 2021 21:09
@rectified95
Copy link
Collaborator

@burtonrodman Since this repo lacks a Windows CI, can you perhaps provide a screenshot showing a successful build in VS?

@burtonrodman
Copy link
Contributor Author

image

@rectified95 rectified95 merged commit 603ac79 into react-native-datetimepicker:master Apr 28, 2021
@vonovak
Copy link
Member

vonovak commented May 17, 2021

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants