Skip to content

chore: Update test app template #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Apr 23, 2024

Summary

Another further example to reduce the footprint of #879 , this PR splits out a bunch of the changes and does the following:

  • Updates RNTA to 3.0.11 (the last one where Android E2E tests on new architecture work, it seems this change breaks detox)
  • re-initializes the test app (I did my best to preserve custom setup for having metro hot reload changes from root and add detox, etc)

Test Plan

CI should pass

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@Saadnajmi
Copy link
Contributor Author

OK, so new arch Android fails here too. That means it's not the 0.73 update but something in the RNTA template update I am breaking. Good to know :D

@Saadnajmi
Copy link
Contributor Author

Saadnajmi commented Apr 23, 2024

Update 2: The issue is somewhere between RNTA 3.0.0 (works) and RNTA 3.1.0 (fails)

@Saadnajmi
Copy link
Contributor Author

Closing in favor of #879

@Saadnajmi Saadnajmi closed this Apr 24, 2024
@Saadnajmi Saadnajmi deleted the template branch April 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant