Initial setup for webpack-4

[GeertWille]

Hey,

Initial setup for webpack 4. I tested some examples and they all seemed to work fine. Please test it out with your projects and post the issues you get here.

Thanks!

[denis-sokolov]

• A major version number bump. React-static exposes webpack config to the client, and in my case, I rely on Webpack 3 plugins. The upgrade will be breaking backwards compatibility.
• extractCssChunks option relies on the extract-css-chunks-webpack-plugin plugin, which is not updated for Webpack 4.
• Once we are able to migrate to Webpack 4, let’s remember to revisit webpack-serve in Consider webpack-serve over webpack-dev-server #503.

[poorpaddy]

I believe this is no longer being supported or contributed to. See webpack-contrib/extract-text-webpack-plugin#749.

You may want to follow the pattern in this PR which uses mini-css-extract-plugin instead: https://github.com/phoenixframework/phoenix/pull/2831/files

[sudarshang]

How can I help get this PR merged?

[JustFly1984]

"extract-hoc": "^0.0.5" and "extract-hoc-compose": "^0.0.1" does not required by HMR@4, which is supported by react-static. 2018-05-07 23:51 GMT+08:00 Sudarshan Gaikaiwari <[email protected]>:

…

How can I help get this PR merged? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJsebqyY5d-XoD6tEegB65HL-2FweGZks5twG1sgaJpZM4Snzyj> .

[sudarshang]

I have a new PR out #605, that addresses most of the concerns raised here. Please have a look and give feedback.

[tannerlinsley]

Going with #605