Skip to content

Add legend support to charts #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2017

Conversation

ekscentrysytet
Copy link

Legend object passed to options. See legend docs

@jerairrest
Copy link
Collaborator

Do you have an example we can add to the main site for this change? That would be awesome to have. Thanks!

@ekscentrysytet
Copy link
Author

@jerairrest I've included examples on my commit

@jerairrest jerairrest changed the base branch from master to rc-2.5.0 July 15, 2017 15:51
@jerairrest jerairrest merged commit e5b1a1a into reactchartjs:rc-2.5.0 Jul 15, 2017
@alejo90
Copy link

alejo90 commented Jul 19, 2017

I believe this change introduced a bug. I am working on a single page application and I set my line chart to not display the legend. After navigating to another route and back, the legend is rendered. This behavior was not present in v2.4.1. In addition, the global defaults.legend.display is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants