Remove all runtime reliance on NPM #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
no-more-npm-install
branch
4 times, most recently
from
5090c84 to
2db6071
Compare
rmorshea
force-pushed
the
no-more-npm-install
branch
16 times, most recently
from
81c124d to
0ff0146
Compare
With recent changes to the custom component interface, it's now possible to remove all runtime reliance on NPM. Doing so has many virtuous knock-on effects: 1. Removal of large chunks of code 2. Greatly simplifies how users dynamically experiment with React component libraries, because their usage no longer requires a build step. Instead they can be loaded in the browser from a CDN that distributes ESM modules. 3. The built-in client code needs to make fewer assumption about where static resources are located, and as a result, it's also easier to coordinate the server and client code. 4. Alternate client implementations benefit from this simplicity. Now, it's possible to install idom-client-react normally and write a loadImportSource() function that looks for route serving the contents of IDOM_WEB_MODULES_DIR. This change includes large breaking changes: - The CLI is being removed as it won't be needed any longer - The idom.client is being removed in favor of a stripped down idom.web module - The IDOM_CLIENT_BUILD_DIR config option will no longer exist and a new IDOM_WEB_MODULES_DIR which only contains dynamically linked web modules. While this new directory's location is configurable, it is meant to be transient and should not be re-used across sessions. The new idom.web module takes a simpler approach to constructing import sources and expands upon the logic for resolving imports by allowing exports from URLs to be discovered too. Now, that IDOM isn't using NPM to dynamically install component libraries idom.web instead creates JS modules from template files and links them into IDOM_WEB_MODULES_DIR. These templates ultimately direct the browser to load the desired library from a CDN.
also includes: - fix issue where client did not remove fallback from DOM - add option to symlink module_from_file into web modules dir
rmorshea
force-pushed
the
no-more-npm-install
branch
from
0ff0146 to
5b00486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent changes to the custom component interface, it's now possible to remove all runtime reliance on NPM. Doing so has many virtuous knock-on effects:
loadImportSource()function that looks for route serving the contents ofIDOM_WEB_MODULES_DIR.This change includes large breaking changes:
idom.clientis being removed in favor of a stripped downidom.webmoduleIDOM_CLIENT_BUILD_DIRconfig option will no longer exist and a newIDOM_WEB_MODULES_DIRwhich only contains dynamically linked web modules. While this new directory's location is configurable, it is meant to be transient and should not be re-used across sessions.The new
idom.webmodule takes a simpler approach to constructing import sources and expands upon the logic for resolving imports by allowing exports from URLs to be discovered too. Now, that IDOM isn't using NPM to dynamically install component librariesidom.webinstead creates JS modules from template files and links them intoIDOM_WEB_MODULES_DIR. These templates ultimately direct the browser to load the desired library from a CDN.