rework custom component interface with bind() func #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
render-children-in-template
branch
from
109e03a to
b1a159f
Compare
also... - updated the react module template to render children - removed preact module template until things are more stable (it was not being tested).
rmorshea
force-pushed
the
render-children-in-template
branch
from
b1a159f to
bcf05de
Compare
this is less than ideal - as such #461 has been created in order to try and track down what the problem is. in short victory charts do not update unless explicitely unmounted before updating. ReactDOM.render should work as expected, but for whatever reason it is not here.
rmorshea
force-pushed
the
render-children-in-template
branch
from
85c0c78 to
cbc9cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also...
(it was not being tested).