-
-
Notifications
You must be signed in to change notification settings - Fork 324
Fix idom.run
uvicorn self.servers exception
#943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix idom.run
uvicorn self.servers exception
#943
Conversation
The On a tangent, we should probably set |
Yeah, my bad. I deleted the old ReactPy releases not realizing that once I deleted the last one the name would become available again so was stressing trying to get a release out ASAP. |
Also, |
@rmorshea Do you agree with removing |
If we remove the tests we should probably just remove the feature entirely. |
I don't feel like this PR was appropriate to remove |
This PR makes
idom.run
utilize the same code asuvicorn.run
in order to prevent unexpected exceptions.See encode/uvicorn#1845 for details
Checklist
Please update this checklist as you complete each item:
changelog.rst
has been updated with any significant changes.