Skip to content

rewrite the client in typescript #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 23, 2023
Merged

rewrite the client in typescript #951

merged 16 commits into from
Mar 23, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Mar 7, 2023

closes: #743

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea force-pushed the typescript branch 7 times, most recently from 8319bb6 to ff2a9d3 Compare March 7, 2023 19:29
@rmorshea rmorshea changed the title initial work to rewrite the client in typescript rewrite the client in typescript Mar 8, 2023
@rmorshea
Copy link
Collaborator Author

rmorshea commented Mar 8, 2023

@rmorshea rmorshea marked this pull request as ready for review March 8, 2023 07:02
@rmorshea rmorshea force-pushed the typescript branch 2 times, most recently from b7fc787 to b6f1051 Compare March 15, 2023 04:42
@Archmonger
Copy link
Contributor

This might also be a good time to add in ES6 classes. Having a bunch of raw functions makes things harder to read.

@rmorshea rmorshea force-pushed the typescript branch 2 times, most recently from b6f1051 to 1d3afdd Compare March 15, 2023 06:49
@rmorshea
Copy link
Collaborator Author

Yup. I'm using all the modern features here. Hoping this will be easier to contribute to moving forward after these changes.

@rmorshea rmorshea merged commit 82a8bd6 into main Mar 23, 2023
@rmorshea rmorshea deleted the typescript branch March 23, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite client with Typescript
2 participants