-
Notifications
You must be signed in to change notification settings - Fork 296
renderToNodeStream translation #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b0f0c67
renderToNodeStream translation
cosmoart 007499f
Merge branch 'reactjs:main' into main
cosmoart a8974a8
Merge branch 'reactjs:main' into main
cosmoart a1bb3d0
Merge branch 'reactjs:main' into main
cosmoart f358b7c
Merge branch 'main' into main
carburo 1d841ff
Update beta/src/content/reference/react-dom/server/renderToNodeStream.md
cosmoart 5e9f153
Update beta/src/content/reference/react-dom/server/renderToNodeStream.md
cosmoart 0414426
Update beta/src/content/reference/react-dom/server/renderToNodeStream.md
cosmoart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me pregunto si deberíamos traducir «Readable» en «Readable Stream». Hasta el momento no he visto una traducción asentada y puede ser difícil para el lector saber de qué realmente se está hablando. ¿Qué criterio aplicaste para no traducir «Stream», pero sí «Readable»? Quisiera saber tu opinión en este caso, porque no tengo muy claro cuál sería la mejor opción.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mis opciones de traducción fueron «Flujo legible de Node.js» y «Stream legible de Node.js». Elegí la segunda opción porque:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sí, el hecho de que no haya una consenso sobre qué término usar es el principal punto de mi comentario original
Seguramente será uno de los términos a revisitar luego de que se hayan hecho todas las traducciones para lograr una consistencia entre las diversas páginas de la documentación. De momento me parece bien y creo que podemos mezclar los cambios así.