-
Notifications
You must be signed in to change notification settings - Fork 131
Translated Render & Commit Page #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Added review till line 65.
Lets get these closed, the we can continue further with review.
For our review process you can refer #23
@arshadkazmi42 Thank you, I have done the changes you have asked for till line 65, also I made sure that whatever word changes or spelling changes you have suggested I have changed it globally throughout the file, awaiting your response for some doubts will commit once they are cleared. |
@arshadkazmi42 updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good going.
I have added review till line 146.
Lets get these closed then we can continue further.
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
"Resolved Merge conflicts and updated some lines"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with the fixes.
I have added review for rest of the file.
Once these are fixed, we can get this merged.
@arshadkazmi42 Done with the changes you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
Let's get this merged.
Thank you for working on this
Updated the
Render & Commit
Page with Hindi Translations.render-and-commit.md