Skip to content

Translated Render & Commit Page #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2022
Merged

Conversation

Rohan-Makwana
Copy link
Contributor

Updated the Render & Commit Page with Hindi Translations.
render-and-commit.md

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Added review till line 65.

Lets get these closed, the we can continue further with review.

For our review process you can refer #23

@Rohan-Makwana
Copy link
Contributor Author

@arshadkazmi42 Thank you, I have done the changes you have asked for till line 65, also I made sure that whatever word changes or spelling changes you have suggested I have changed it globally throughout the file, awaiting your response for some doubts will commit once they are cleared.

@Rohan-Makwana
Copy link
Contributor Author

@arshadkazmi42 updated the Render and Commit page with all the changes you mentioned. I think the file is perfect now. Awaiting your review.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good going.

I have added review till line 146.

Lets get these closed then we can continue further.

@github-actions
Copy link

github-actions bot commented Feb 19, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/render-and-commit 58.78 KB (🟡 +1.37 KB) 153.89 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

"Resolved Merge conflicts and updated some lines"
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.

I have added review for rest of the file.

Once these are fixed, we can get this merged.

@Rohan-Makwana
Copy link
Contributor Author

@arshadkazmi42 Done with the changes you mentioned.
I think this pull request #179 is ready to be merged, awaiting your review.
Thank you.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉
Let's get this merged.

Thank you for working on this

@arshadkazmi42 arshadkazmi42 merged commit dbf799e into reactjs:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants