-
Notifications
You must be signed in to change notification settings - Fork 131
Translated Writing Markup with JSX Page #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this up.
I have added review till line 30.
Lets get these fixed, then we can continue further with the review.
Before starting on the fixes, I will suggest to read about our review process here #23
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
@arshadkazmi42 I have updated the changes, let me know if there's something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work with the fixes.
I have added review till line 124.
Lets get these fixed and then we can continue further with the review
@Anku5hk You have missed few of the comments. Can you work on those? |
Okay I have updated the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great going.
I have added more review till line 219.
Lets get these closed then we can continue with further review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
I have added few more comments, Once these are fixed, we can get this merged.
@arshadkazmi42 I have updated the text, let me know if there's something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
Thank you for working on this.
Lets get this merged 🎉
Added Hindi Translation for Writing Markup with JSX page.