Skip to content

API Reference > Test Utilities #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jun 13, 2020
Merged

API Reference > Test Utilities #45

merged 43 commits into from
Jun 13, 2020

Conversation

paramaggarwal
Copy link
Contributor

@paramaggarwal paramaggarwal commented Aug 23, 2019 •
edited
Loading

  • Overview
  • Reference
    • act()
    • mockComponent()
    • isElement()
    • isElementOfType()
    • isDOMComponent()
    • isCompositeComponent()
    • isCompositeComponentWithType()
    • findAllInRenderedTree()
    • scryRenderedDOMComponentsWithClass()
    • findRenderedDOMComponentWithClass()
    • scryRenderedDOMComponentsWithTag()
    • findRenderedDOMComponentWithTag()
    • scryRenderedComponentsWithType()
    • findRenderedComponentWithType()
    • renderIntoDocument()
  • Other Utilities
    • Simulate

@netlify
Copy link

netlify bot commented Aug 23, 2019

Deploy preview for hi-reactjs ready!

Built with commit c40d883

https://deploy-preview-45--hi-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Aug 23, 2019 •
edited
Loading

Deploy preview for hi-reactjs ready!

Built with commit 0eaa33c

https://deploy-preview-45--hi-reactjs.netlify.app

@arshadkazmi42
Copy link
Member

@paramaggarwal Good start. Let me know once you are done translating the whole file. I will start the review

@paramaggarwal paramaggarwal changed the title [WIP] API Reference > Test Utilities API Reference > Test Utilities Sep 16, 2019
@arshadkazmi42
Copy link
Member

Ready.

Awesome. I will start reviewing this later today.

arshadkazmi42
arshadkazmi42 requested changes Sep 16, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.
I have added some feedbacks till line 124.

For review process do read #23

@paramaggarwal
Copy link
Contributor Author

Thanks for the excellent feedback. I have addressed everything raised till now. We can continue further review.

arshadkazmi42
arshadkazmi42 requested changes Sep 17, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.
I have reviewed the whole file and add couple of more feedbacks.
Once these are fixed it will be good to go from my end for second phase of review

arshadkazmi42
arshadkazmi42 approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯
This is good to go from my end.
For next steps, there will be a second round of review done by @saranshkataria. Once that is done, we will get this merged

@paramaggarwal
Copy link
Contributor Author

Comments addressed. Sorry for previously marking comments as "Resolved" - have not done so this time.

@arshadkazmi42 arshadkazmi42 added the 2nd Review Second phrase of review label Jan 24, 2020
@saranshkataria
Copy link
Member

@paramaggarwal this has become confusing a bit to check which ones were resolved and which ones were not. Marking everything as resolved and starting the review afresh.

saranshkataria
saranshkataria reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments till line 220

@saranshkataria
Copy link
Member

@paramaggarwal there are quite a few pending points. Could you look into those as well before we proceed with the review?

@paramaggarwal
Copy link
Contributor Author

Ready.

saranshkataria
saranshkataria reviewed May 22, 2020
View reviewed changes
Copy link
Member

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added final set of changes needed. Then this will be good to 👍

@paramaggarwal
Copy link
Contributor Author

Ready.

@saranshkataria
Copy link
Member

LGTM, Thanks! Merging it in

@saranshkataria saranshkataria merged commit 3add710 into reactjs:master Jun 13, 2020
@paramaggarwal
Copy link
Contributor Author

Thanks a lot @saranshkataria and @arshadkazmi42 👍

@paramaggarwal paramaggarwal deleted the addons-test-utils branch June 14, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saranshkataria saranshkataria saranshkataria approved these changes

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees
No one assigned
Labels
2nd Review Second phrase of review awaiting author response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paramaggarwal @arshadkazmi42 @saranshkataria