-
Notifications
You must be signed in to change notification settings - Fork 131
added hindi translation for js environment requirement #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for hi-reactjs ready! Built with commit dafd432 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some review.
Also you need to translate complete file in hindi.
Title links should go to the parent repository https://github.com/reactjs/reactjs.org
can you tell me what i need to convert in hindi , and which title link should go to parent repo. I didn't get what needs to be modified |
All the text in the file should be translated to hindi. You can check this PR for reference |
English Words i have used are React, Map, Set, requestAnimationFrame, core-js, babel-pollyfill, pollyfill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have given few examples on how to translate.
Also I have not marked few of the lines which should be translated. You should look into other lines also, which I might not have marked.
Marked lines are for example.
Complete file needs to be translated in similar way.
Hope this helps to get you started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Add few reviews. Once those are handled, its good to go from my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💯
Looks good to me.
For next steps @saranshkataria will be doing a second review and after that we will get this merged.
Thank you for all the awesome work you have done 🎉
Great work, added some comments and this is good to go once fixed! |
Done |
LGTM, Thank you! |
No description provided.