Skip to content

added translations for Babel, JSX, and Build Steps #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2019
Merged

added translations for Babel, JSX, and Build Steps #50

merged 2 commits into from
Oct 3, 2019

Conversation

shobhitsingh29
Copy link
Contributor

@shobhitsingh29 shobhitsingh29 commented Oct 1, 2019 •
edited
Loading

  • Babel, JSX, and Build Steps

Before :
Screenshot 2019-10-02 at 4 11 43 AM
After :
Screenshot 2019-10-02 at 4 13 25 AM

@shobhitsingh29 shobhitsingh29 changed the title added translations for Babel, JSX, and Build Steps added translations for *Babel, JSX, and Build Steps* Oct 1, 2019
@shobhitsingh29 shobhitsingh29 changed the title added translations for *Babel, JSX, and Build Steps* added translations for Babel, JSX, and Build Steps Oct 1, 2019
@netlify
Copy link

netlify bot commented Oct 1, 2019 •
edited
Loading

Deploy preview for hi-reactjs ready!

Built with commit 25188a6

https://deploy-preview-50--hi-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Oct 2, 2019
Closed
88 tasks
@shobhitsingh29
Copy link
Contributor Author

@arshadkazmi42 can you review this 😄

arshadkazmi42
arshadkazmi42 requested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this up.
I have left couple of feedbacks.
Once those are fixed, its good to go from my end

@shobhitsingh29
Copy link
Contributor Author

@arshadkazmi42 done with review comments

arshadkazmi42
arshadkazmi42 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Thank you for working on this.

@arshadkazmi42 arshadkazmi42 merged commit 6297831 into reactjs:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobhitsingh29 @arshadkazmi42 @shobhit-singh-29