Translation of the page "Conditional rendering" #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a non-empty link title (translated) we get undefined Changing the default to the translated version and leaving them empty fixes the issue
imported codepen examples into source code I'll ask if it's the case of doing that upstream as well for better... "translatability" 😂
|
Deploy preview for it-react-org failed. Built with commit 3f9d55f https://app.netlify.com/sites/it-react-org/deploys/5c7772d5f17498000757d775 |
deblasis
changed the title
deblasis
added
needs +1
|
Deploy preview for it-reactjs ready! Built with commit 3f9d55f |
|
Closes #21 |
LucaBlackDragon
requested changes
Feb 27, 2019
Co-Authored-By: deblasis <[email protected]>
LucaBlackDragon
added
✔ translated
and removed
needs +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the translation itself, notable changes:
Caused by the fact that we had non-empty description for "local" CodePen examples