Skip to content

Translation for the page 'Basics -> Thinking in React' #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 18, 2019
Merged

Translation for the page 'Basics -> Thinking in React' #122

merged 7 commits into from
Mar 18, 2019

Conversation

deblasis
Copy link
Collaborator

@deblasis deblasis commented Mar 6, 2019

Closes #26

Things to note:

  • I have added Codesandbox embedded examples with the relevant gatsby plugin to support that.
  • I configured it to reflect styling and behaviour of the CodePen one.

@deblasis deblasis added needs +1 Needs an approval before merging (not from the author) 💪 long page - more than 100 lines Looooong page, expect delays! labels Mar 6, 2019
@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for it-react-org ready!

Built with commit 7e925a1

https://deploy-preview-122--it-react-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for it-reactjs ready!

Built with commit 7e925a1

https://deploy-preview-122--it-reactjs.netlify.com

@deblasis
thinking-in-react: prettier... weirdness
f93decb 
"--write" changed this file but it looks like that
CircleCI doesn't like it...

reverting
LucaBlackDragon
LucaBlackDragon requested changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@LucaBlackDragon LucaBlackDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK, I would just translate the comment inside examples/thinking-in-react/3/index.html:

<div id="container">
    <!-- I contenuti di questo elemento verranno rimpiazzati dal tuo componente. -->
</div>

@deblasis deblasis added ✔ translated and removed needs +1 Needs an approval before merging (not from the author) labels Mar 18, 2019
@deblasis deblasis merged commit 0ff401b into master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaBlackDragon LucaBlackDragon LucaBlackDragon requested changes

@lssmn lssmn Awaiting requested review from lssmn

Assignees
No one assigned
Labels
💪 long page - more than 100 lines Looooong page, expect delays! ✔ translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deblasis @LucaBlackDragon