-
Notifications
You must be signed in to change notification settings - Fork 84
Sync with reactjs.org @ 0057efa1 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dan Abramov <[email protected]> Co-authored-by: Sylwia Vargas <[email protected]> Co-authored-by: Dan Lebowitz <[email protected]> Co-authored-by: Razvan Gradinar <[email protected]> Co-authored-by: Jared Palmer <[email protected]> Co-authored-by: Dane Grant <[email protected]> Co-authored-by: Dustin Goodman <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> Co-authored-by: Maggie Appleton <[email protected]> Co-authored-by: Alex Moldovan <[email protected]> Co-authored-by: Ives van Hoorne <[email protected]> Co-authored-by: Brian Vaughn <[email protected]> Co-authored-by: Dmitri Pavlutin <[email protected]>
Co-authored-by: Lee Robinson <[email protected]>
Co-authored-by: Hao-Ping <[email protected]>
The `appId` was retrieved from props but the `<Search>` component is never instantiated with props. So the preconnect link targeted an unknown search cluster: ```html <link rel="preconnect" href="https://undefined-dsn.algolia.net" crossorigin="true"> ``` This fixes the preconnect link by getting the `appId` from the website config.
* fix: googleTranslate breaking terminal blocks * chore: prettier magic
This reverts commit 446c15c195f36c0640366c9df22cba6ea0370166.
Co-authored-by: Alexey Pyltsyn <[email protected]>
Co-authored-by: Dan Abramov <[email protected]>
* Fix case-sensitive search term in example. Converting both the name and search value to lowercase solves case sensitive searching. * Update thinking-in-react.md * Update thinking-in-react.md * Update thinking-in-react.md Co-authored-by: Dan Abramov <[email protected]>
* Take system's theme for the site * Add IIFE for dark mode in document load and preserve in localStorage * Add types * Fix SSR and respect override Co-authored-by: Dan Abramov <[email protected]>
* Make sandbox themeable * Fix gutters * Fix FOUCs Co-authored-by: Dan Lebowitz <[email protected]>
* Fixes wrong breadcrumb for 404 page * Change Home as default layout * Add layout Learn to the pages inside learn
* Add git hook to generate headings ids * Fixes "Analyze Bundle" workflow
* Allow page zooming/scaling * Fix for iOS
* chore: fix typo * Update referencing-values-with-refs.md * Fix typo of typo Co-authored-by: Alexey Pyltsyn <[email protected]>
* Fix two unicode whitespaces which are invalid * Use custom ID format that works better with MDX 2 * Fix sebastian * remark-slug as dev dep
* fix-collapsable-color * Made Eslint work and added next's eslint config * Add lint:fix to pre commit rule * Reverts older anchor links * Fixed review comments * Replace with spaces like before * Update DocsFooter.tsx * Update arrow function * Update CodeBlock.tsx * Update MDXComponents.tsx * Update SidebarLink.tsx
* Add prettier before commit and during CI * Add workflow * Reverse merge main to branch * dry run prettier * dry run prettier * [warn] jsxBracketSameLine is deprecated so replaced it to bracketSameLine * Revert "[warn] jsxBracketSameLine is deprecated so replaced it to bracketSameLine" This reverts commit 43dbe9ed3fba10b03a90d989cf90b4af4efd2212. * Revert "dry run prettier" This reverts commit b62948042cd8f8addf8ee23110de4096a8630926. * Revert "dry run prettier" This reverts commit 382f9a4691dee04673e461b3eda0d52c1aefda3b. * Revert "Reverse merge main to branch" This reverts commit 43667eaf29b9ab4266397251c8d781f611dcdcf8. * [warn] jsxBracketSameLine is deprecated so replaced it to bracketSameLine
Adds a note to the top of the page linking to the 18 Beta announcement.
* added word break * Update PageHeading.tsx
* Update package.json * Update README.md * Update package.json * Add tsc for check-all as well * Update README.md * Update README.md Co-authored-by: Dan Abramov <[email protected]>
Fixes #326, Fixes #325 Signed-off-by: Alessandro De Blasis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 0057efa
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.