Skip to content

Translate "Preserving and Resetting State" #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented May 16, 2023

"Preserving and Resetting State" の翻訳です

@github-actions
Copy link

github-actions bot commented May 16, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.87 KB (🟡 +6 B) 171.5 KB
/500 77.86 KB (🟡 +6 B) 171.49 KB
/[[...markdownPath]] 79.29 KB (🟡 +6 B) 172.92 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@smikitky smikitky force-pushed the tr/preserving-state branch from 251cd58 to 946cc7d Compare May 17, 2023 10:53
@smikitky smikitky marked this pull request as ready for review May 17, 2023 10:54
@smikitky smikitky requested review from koba04 and potato4d May 17, 2023 10:54
@@ -688,35 +688,35 @@ label {

</Sandpack>

The counter state gets reset when you click the checkbox. Although you render a `Counter`, the first child of the `div` changes from a `div` to a `section`. When the child `div` was removed from the DOM, the whole tree below it (including the `Counter` and its state) was destroyed as well.
チェックボックスをクリックするとカウンタの state がリセットされます。`Counter` をレンダーしていることは同じでも、`<div>` の最初の子が `section` から `div` に変わっています。子側の `section`DOM から削除されたとき、その下のツリー全体(`Counter` とその state を含む)も破棄されたのです。
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは明らかに原文のミスなので本来の意図と思われる通りに訳しています。原文に PR だしてあります。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!!!

@smikitky smikitky merged commit dcdde83 into main May 31, 2023
@smikitky smikitky deleted the tr/preserving-state branch May 31, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants