Skip to content

Update typechecking-with-proptypes.md #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2021
Merged

Update typechecking-with-proptypes.md #325

merged 2 commits into from
Jun 26, 2021

Conversation

ABlued
Copy link
Contributor

@ABlued ABlued commented Jun 21, 2021 •
edited
Loading

@ABlued
Copy link
Contributor Author

ABlued commented Jun 21, 2021 •
edited
Loading

// English

There is a part in the React official Korean document that is not translated into Korean.

// An object with warnings on extra properties

If you translate this part, it becomes an '// 추가 프로퍼티에 대한 경고가 있는 객체'.
We need to change this part.

// Korean

react 한국 공식 문서에 한국어로 번역되어 있지 않은 부분이 있습니다.

// An object with warnings on extra properties

이 부분을 번역해보면 '// 추가 프로퍼티에 대한 경고가 있는 객체' 가 됩니다.
이 부분에 대한 변경이 필요합니다.

@netlify
Copy link

netlify bot commented Jun 21, 2021 •
edited
Loading

✔️ Deploy Preview for ko-reactjs-org ready!

🔨 Explore the source changes: 7f2d2b5

🔍 Inspect the deploy log: https://app.netlify.com/sites/ko-reactjs-org/deploys/60d5cfa1b88d31000702f6da

😎 Browse the preview: https://deploy-preview-325--ko-reactjs-org.netlify.app

hg-pyun
hg-pyun approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taehwanno taehwanno merged commit 455f7dd into reactjs:master Jun 26, 2021
@taehwanno
Copy link
Member

기여해주셔서 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno taehwanno approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ABlued @taehwanno @hg-pyun