Skip to content

Translate 'Using the Effect Hook' page #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 19, 2019
Merged

Translate 'Using the Effect Hook' page #50

merged 16 commits into from
Mar 19, 2019

Conversation

g12i
Copy link
Contributor

@g12i g12i commented Mar 9, 2019

@g12i g12i added the work in progress Author opened the pull-request but it's still being worked on label Mar 9, 2019
@g12i g12i changed the title Translate 'Using the Effect Hok' page #wip Translate 'Using the Effect Hook' page #wip Mar 9, 2019
@netlify
Copy link

netlify bot commented Mar 9, 2019

Deploy preview for pl-reactjs ready!

Built with commit 65ee6c0

https://deploy-preview-50--pl-reactjs.netlify.com

@g12i g12i changed the title Translate 'Using the Effect Hook' page #wip Translate 'Using the Effect Hook' page Mar 17, 2019
@g12i g12i added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 17, 2019

Data fetching, setting up a subscription, and manually changing the DOM in React components are all examples of side effects. Whether or not you're used to calling these operations "side effects" (or just "effects"), you've likely performed them in your components before.
Pobieranie danych, tworzenie subskrypcji czy ręczna ingerencja w drzewo DOM z wewnątrz komponentów - to wszystko przykłady efektów ubocznych. Nie zależnie od tego, czy nazywane „efektami ubocznymi” (lub po prostu „efektami”) najprawdopodobniej przeprowadzałaś(-eś) je wcześniej.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pobieranie danych, tworzenie subskrypcji czy ręczna ingerencja w drzewo DOM z wewnątrz komponentów - to wszystko przykłady efektów ubocznych. Nie zależnie od tego, czy nazywane „efektami ubocznymi” (lub po prostu „efektami”) najprawdopodobniej przeprowadzałaś(-eś) je wcześniej.
Pobieranie danych, tworzenie subskrypcji czy ręczna ingerencja w drzewo DOM z wewnątrz komponentów - to wszystko przykłady efektów ubocznych. Niezależnie od tego, czy znasz je pod nazwą „efekty uboczne” (lub po prostu „efekty”), najprawdopodobniej masz je zaszyte gdzieś w swoim kodzie.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g12i Celowo pominąłeś tę sugestię? "Niezależnie" na pewno powinieneś napisać razem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakubdrozdek - ach tak, miałem się nad tymi dwoma zastanowić, przed zmergowaniem, ale wyleciało mi to z głowy. Tu mi nie pasowało to zaszyte w kodzie, a w tym drugim nawet nie pamiętam co. Dobrze, że to zmergowaliście, trzeba iść do przodu :).

@jakubdrozdek jakubdrozdek added this to the Other Pages milestone Mar 17, 2019
@jakubdrozdek jakubdrozdek added the needs +1 Needs another approval before merging label Mar 17, 2019
@g12i g12i requested a review from a team March 18, 2019 19:51
@cvqprs cvqprs added 🌐 translated Translation is completed for this page can be merged and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Mar 19, 2019
@jakubdrozdek jakubdrozdek merged commit ef4a69a into master Mar 19, 2019
@jakubdrozdek jakubdrozdek deleted the hooks-effect branch March 19, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants