Skip to content

Update react to 15.6.2 #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2017
Merged

Update react to 15.6.2 #789

merged 3 commits into from
Sep 27, 2017

Conversation

BookOfGreg
Copy link
Member

Update bundled React to 15.6.2

I know React 16 is out next week. Worth shipping this now or wait until next week anyway? Be good to have a gem release with the latest 15.x and let people update to 16.x at will.

@rmosolgo Should we cut a gem release too with all the new goodies in? I could look into 774 is that's the only oddity we've seen.

@rmosolgo
Copy link
Member

release with the latest 15.x and let people update to 16.x at will.

totally agree!

@BookOfGreg
Copy link
Member Author

Thought React 16 was next week, looks like it got released just now!
I'll have to spend some time tomorrow to see why tests didn't pass just there and see if we can get a few releases out.

@BookOfGreg
Copy link
Member Author

BookOfGreg commented Sep 27, 2017

bundle exec appraisal rails-5.1-sprockets_4 rake test TESTOPTS="--seed=56135" seems to work.
Not sure why it's failing in travis. Will bump a file to get it to re-run.

The new deprecation warnings for React16: Warning: Accessing factories like React.DOM.div has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead. are going to need me to cleanup a few things but that's for another PR.

@BookOfGreg BookOfGreg merged commit e99592f into reactjs:master Sep 27, 2017
@BookOfGreg BookOfGreg deleted the update-react branch September 27, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants