Support camelizing ActionController::Parameters #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for React.camelize_props to camelize an instance of ActionController::Parameters hash, so that permitted, strong parameters in a Rails controller can be passed to a React component. Resolves reactjs#931
BookOfGreg
reviewed
Sep 7, 2018
| @@ -28,4 +28,23 @@ def test_it_camelizes_props | |||
|
|
|||
| assert_equal expected_props, React.camelize_props(raw_props) | |||
| end | |||
|
|
|||
| def test_it_camelizes_params | |||
There was a problem hiding this comment.
You can actually wrap the test in a defined check like this:
if defined?(ActionController::Parameters)
def test_method
end
end
Which should make it work on Rails <4
Edit: Though technically speaking we don't support Rails3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for React.camelize_props to camelize an instance of
ActionController::Parameters hash, so that permitted, strong parameters
in a Rails controller can be passed to a React component.
Other Information
Resolves #931