-
Notifications
You must be signed in to change notification settings - Fork 756
Keep variable name case sensitive on assert_react_component props. #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep variable name case sensitive on assert_react_component props. #979
Conversation
@@ -4,7 +4,7 @@ | |||
</ul> | |||
|
|||
<div id='component-parent'> | |||
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %> | |||
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the same in the other dummy applications?
That should make the tests pass.
test/dummy_sprockets/app/views/pages/show.html.erb
test/dummy_webpacker1/app/views/pages/show.html.erb
test/dummy_webpacker2/app/views/pages/show.html.erb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask you to also get the one in this file please?
https://github.com/reactjs/react-rails/blob/master/test/dummy_sprockets/app/views/pages/show.html.erb
cbdfb42
to
e4eb626
Compare
Just updated. BTW, why I run test on my local always have this errors:
|
Not sure why it happens but I saw that myself. I had to CD into each test directory and remove the node_modules folder from each one. The rake task will try |
We need make sure the prop name is correct, because JavaScript used that it's case sensitive.
e4eb626
to
4158231
Compare
Thanks for this one! I'll set an alarm so I can get it shipped out this week. |
We need make sure the prop name is correct, because JavaScript used that it's case sensitive.
for example:
@BookOfGreg