-
-
Notifications
You must be signed in to change notification settings - Fork 448
Add environment prop #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment prop #365
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
/** | ||
* @jest-environment node | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Allowed this tests to run on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did accessing window crash the test? Or how did you notice this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it was because of having the tests failing on CI: https://travis-ci.org/github/reactjs/react-tabs/builds/753987091 |
||
*/ | ||
/* eslint-env jest */ | ||
import React from 'react'; | ||
import Tab from '../Tab'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping this into a function that runs only once (since initially
canUseActiveElement
isundefined
) to be able to use theenvironment
from the props instead of assumingwindow
.