Skip to content

chore: remove/update pinned gatsby-remark-prismjs plugin #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Oct 12, 2018

We fixed this in gatsbyjs/gatsby#9044 🎉

We originally fixed the issue by pinning in #1202

Deploy preview of originally buggy line indenting page

screen shot 2018-10-12 at 4 16 42 pm

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit c6f5f4b

https://deploy-preview-1253--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@DSchau
Copy link
Contributor Author

DSchau commented Oct 12, 2018

One note here: I just ran yarn add gatsby-remark-prismjs@latest and it seems to have added a bunch of integrity checks to yarn.lock.

Not quite sure what that's about! I'm thinking it's something in later versions of yarn, perhaps?

@alexkrolick
Copy link
Collaborator

Yes, yarn 1.10 added the integrity checks. Let's keep them.

@gaearon gaearon merged commit 08a6a90 into reactjs:master Oct 12, 2018
@gaearon
Copy link
Member

gaearon commented Oct 12, 2018

thanks

@DSchau DSchau deleted the gatsby/gatsby-remark-prismjs-unpin branch October 12, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants