Skip to content

fix wrong quotes around inline codes #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Dec 28, 2023

related:

The root cause is fixing on remark-smartypants: here
But It's hard to tell when it gets merged so in the meanwhile this typo fix can be helpful.

Edit: The codes seemed to be referred to silvenon/remark-smartypants but we are not depending on that package. They resolved same issue recently so I utilize their fixes in this PR.

after:

image image

Copy link

github-actions bot commented Dec 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.37 KB (🟢 -55 B) 181.19 KB
/500 77.37 KB (🟢 -55 B) 181.18 KB
/[[...markdownPath]] 78.96 KB (🟢 -55 B) 182.78 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@dimaMachina
Copy link

I think no need to merge this PR, let's wait to fix it in the upstream package silvenon/remark-smartypants#80

@2wheeh
Copy link
Contributor Author

2wheeh commented Dec 31, 2023

@dimaMachina Yes, It's merging in no time. I will just change this PR to update dependency once new version releases 😋

@2wheeh
Copy link
Contributor Author

2wheeh commented Jan 5, 2024

@dimaMachina I just found it they don't rely on silvenon/remark-smartypants.
the remark-smartypants here is implemented itself. Sorry for confusing 🥲. can i refer to your work to fix this.

@dimaMachina
Copy link

@2wheeh thank you of course you can refer 👍

@rickhanlonii
Copy link
Member

@2wheeh thanks for fixing this! I'm still seeing it broken in the preview deployment, could you take a look?

Screenshot 2024-01-05 at 11 05 14 AM

@2wheeh
Copy link
Contributor Author

2wheeh commented Jan 5, 2024

@2wheeh thanks for fixing this! I'm still seeing it broken in the preview deployment, could you take a look?

@rickhanlonii Have you checked they are cached ?
On my local, I had to clear node_modules/.cache .

image -> captured from preview deployment building logs.

@rickhanlonii
Copy link
Member

Ah, can you increment the cache key here: https://github.com/reactjs/react.dev/blob/main/src/utils/prepareMDX.js#L10

@2wheeh
Copy link
Contributor Author

2wheeh commented Jan 7, 2024

Ah, can you increment the cache key here: https://github.com/reactjs/react.dev/blob/main/src/utils/prepareMDX.js#L10

@rickhanlonii done it: 1c6d531
and it looks fine in preview now.

except in search bar :
image
image

@rickhanlonii rickhanlonii merged commit 315cb7a into reactjs:main Jan 7, 2024
@rickhanlonii
Copy link
Member

Awesome, thanks! The search should update the index after deploy.

@2wheeh 2wheeh deleted the quotes-around-code branch January 7, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants