-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about useId
being allowed in non-async Server Components
#7715
Open
hernan-yadiel
wants to merge
2
commits into
reactjs:main
Choose a base branch
from
hernan-yadiel:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially, I thought about wording it to highlight that
useId
is the only hook allowed in Server Components. But then I realized this wording assumes that hooks are disallowed in Server Components. Somehow I thought this was just another React Hooks Rule, or another Server Components rule, when actually that’s not exactly the case. I think this assumption is common among devs, maybe because all of them are not allowed in SCs (except fromuseId
which it wasn't even documented).My main concern is that if React later introduces more hooks usable in both Server and Client Components, explaining “some hooks are allowed on server components, others aren't” might get tricky.
I can't think of a clear solution, but perhaps labeling hooks differently could help clarify this distinction. For example, “Interactive Hooks” vs. “Non-Interactive Hooks” (or simply “Hooks”).