Skip to content

Optimized Sidebar UI: Reduced Re-renders & Improved Performance Fixes #7721 #7725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

techwithmuzzu
Copy link

Summary

  • Reduced unnecessary re-renders in Sidebar by using useMemo and useCallback.
  • Improved UI performance by handling pointer-events properly.
  • Ensured expanded state is correctly maintained across navigation.

Changes

  • Optimized SidebarRouteTree.tsx
  • Used react-collapsed efficiently
  • Ensured only necessary updates trigger re-renders

Testing

  • Manually tested by navigating different sections
  • Verified sidebar collapse/expand behavior

@facebook-github-bot
Copy link
Collaborator

Hi @techwithmuzzu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@techwithmuzzu techwithmuzzu changed the title Optimized Sidebar UI: Reduced Re-renders & Improved Performance Optimized Sidebar UI: Reduced Re-renders & Improved Performance Fixes #7721 Apr 7, 2025
@techwithmuzzu
Copy link
Author

🔗 Linked Issue

Fixes #7721

🔧 Fixes

  • Optimized Sidebar UI by reducing unnecessary re-renders.
  • Used useMemo & useCallback for better performance.
  • Ensured expanded state is correctly maintained.

✅ Testing

  • Manually tested navigation and sidebar expand/collapse behavior.

This PR resolves #7721 and improves performance. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants