Skip to content

doc: complete think in react #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 31, 2019
Merged

doc: complete think in react #20

merged 8 commits into from
Mar 31, 2019

Conversation

chloewlin
Copy link
Member

@chloewlin chloewlin commented Feb 20, 2019 •
edited
Loading

Hi, this is my work on thinking in react. A few words I am not sure of:

  • affordance
  • modular 模塊化/模組化
  • implement 實作
  • react doc 文件
  • representation
  • checkbox 複選框
  • attribute / property
  • callbacks

@chloewlin chloewlin changed the title Complete Think in react doc: complete think in react Feb 20, 2019
@tesseralis tesseralis mentioned this pull request Feb 20, 2019
Closed
92 tasks
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit 94eebfa

https://deploy-preview-20--zh-hant-reactjs.netlify.com

@bugtender
Copy link
Member

Hi, @chloewlin Thanks!

we defined

and I think..

  • affordance -> 直觀功能？ ref
  • modular -> 模組化
  • react doc -> react 文件
  • representation -> 呈現方式？

and should keep.

  • keep checkbox -> it's an input type
  • keep property -> we keep properties
  • keep callbacks

last, maybe 數據 would be 資料?

zeroshine
zeroshine reviewed Mar 11, 2019
View reviewed changes
content/docs/thinking-in-react.md Outdated

Though this sounds complex, it's really just a few lines of code. And it's really explicit how your data is flowing throughout the app.
雖然這聽起來負責，但實際上這所用的程式碼很少。而你的數據在應用程式中流動的方向是非常明確的。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

複雜

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zeroshine

@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 4d19645

https://deploy-preview-20--zh-hant-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 26, 2019 •
edited
Loading

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 6db2103

https://deploy-preview-20--zh-hant-reactjs-org.netlify.com

@chloewlin
Copy link
Member Author

@bugtender Thank you for your feedback! Can you take one final quick look on my revisions?

@tesseralis tesseralis requested a review from bugtender March 28, 2019 03:14
bugtender
bugtender reviewed Mar 31, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chloewlin Don't forget to resolve those <<<<<, >>>>> conflict section. 😀

@chloewlin chloewlin added In Review Currently under review and removed Review Needed labels Mar 31, 2019
@chloewlin
Copy link
Member Author

@bugtender Thank you! The conflicts are resolved.

bugtender
bugtender approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍

@chloewlin
Copy link
Member Author

Thank you @bugtender! I am going to merge this in now 🥇

@chloewlin chloewlin merged commit e2b89fe into reactjs:master Mar 31, 2019
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review labels Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshine zeroshine zeroshine left review comments

@bugtender bugtender bugtender approved these changes

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chloewlin @bugtender @zeroshine @neighborhood999