-
Notifications
You must be signed in to change notification settings - Fork 88
[Homepage] initial translation #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chloewlin
merged 10 commits into
reactjs:master
from
itszero:zero/first-pass-at-homepage
Feb 20, 2019
Merged
[Homepage] initial translation #6
chloewlin
merged 10 commits into
reactjs:master
from
itszero:zero/first-pass-at-homepage
Feb 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itszero I left some minor change suggestion, thank you.
Co-Authored-By: itszero <[email protected]>
Thanks for the review. I think i've updated everything! |
Deploy preview for zh-hant-reactjs ready! Built with commit 2bee91e |
Deploy preview for zh-hant-reactjs ready! Built with commit df64cfd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the first stab at the homepage!
We haven't got an official glossary list yet so I'm taking some liberty here. It's mostly straightforward but I decided to rewrite a few sentences to make it more readable. (I prefer to make the translation more readable/smooth rather than stick to the original structure)
I also somewhat localized the examples code a bit so it feels more approachable.
A few comments:
hooks was used in the external plugins example. I removed it to prevent confusion with the React Hooks (and also that word is tricky to translate into TC, I think broader Taiwanese programming community, as in outside of React like Windows MFC community, mostly just use the word hook directly so I'd like to avoid that confusion.)nvm lol. Pulled the master and found out that upstream made the same change too.