Make HttpClient Disposable #88
Comments
nebhale
added a commit
to cloudfoundry/cf-java-client
that referenced
this issue
May 6, 2017
This change adds a dispose() method on the DefaultConnectionContext in order to cleanup any cached resources like connection and thread pools. This method is also marked as @PreDestroy so any DefaultConnectionContext created as a Spring (or EJB) bean will be automatically disposed as part of the standard application lifecycle. This implementation is a temporary solution until reactor/reactor-netty#88 is implemented and available. [resolves #745]
|
It appears that since the defaults, if not configured, are shared across the entire JVM, closing them automatically is wrong. Therefore, there is a reasonable expectation that all custom configured pool and loop resources should be managed by their creator. Therefore this is disposal on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, when finished with an
HttpClient, there is no way to close the (optional)LoopResourcesandPoolResourcescontained within it. You can work around this issue by maintaining references to the configured instances of each of these and disposing them manually yourself, but it would be easier if there was aDisposable#dispose()method on theHttpClientitself, allowing a single call that would clean up all resources maintained by theHttpClient.The text was updated successfully, but these errors were encountered: