Skip to content

Modernize Antora Build #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Modernize Antora Build #3309

merged 1 commit into from
Jun 28, 2024

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Jun 20, 2024

This PR is an attempt to apply some modernization related to Antora gradle build.
It is related to spring-projects/spring-framework#32864

@pderop pderop added the type/documentation A documentation update label Jun 20, 2024
@pderop pderop added this to the 1.2.0-M4 milestone Jun 20, 2024
@pderop pderop self-assigned this Jun 20, 2024
@pderop pderop marked this pull request as draft June 20, 2024 09:34
@pderop
Copy link
Contributor Author

pderop commented Jun 20, 2024

putting this PR in draft mode.
please do not review for now, because the search bar is not working with this PR, I need to check with the docs team.

@pderop pderop force-pushed the modernize-antora-build branch from 89d6887 to fe29938 Compare June 24, 2024 09:33
@pderop pderop force-pushed the modernize-antora-build branch from fe29938 to 1ee5022 Compare June 28, 2024 11:36
@pderop pderop marked this pull request as ready for review June 28, 2024 11:46
@pderop
Copy link
Contributor Author

pderop commented Jun 28, 2024

@violetagg ,

can you check this one ? it's now ready for review.

I have applied few updates from spring-projects/spring-framework#32864
but other updates can't be applied for the moment.

for example, in the 32864, the @springio/antora-extensions allows to applies the recommended Antora extensions in the proper order. But it also applies a new @springio/antora-extensions/set-algolia-env-extension which is problematic and cannot be used in projectreactor as of today.

@pderop pderop requested a review from a team June 28, 2024 11:47
@pderop
Copy link
Contributor Author

pderop commented Jun 28, 2024

@violetagg , thanks!

@pderop pderop merged commit cc30882 into reactor:main Jun 28, 2024
14 checks passed
@pderop pderop deleted the modernize-antora-build branch June 28, 2024 13:37
pderop added a commit that referenced this pull request Jun 28, 2024
@violetagg violetagg added type/chore A task not related to code (build, formatting, process, ...) and removed type/documentation A documentation update labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants