Skip to content

Update Timer.php #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Timer.php #219

wants to merge 1 commit into from

Conversation

cobolfoo
Copy link

Allow user data to be passed to the callback function. This is a much needed feature for complex projects (like the one I am working on) 👍

Allow user data to be passed to the callback function. This is a much needed feature for complex projects (like the one I am working on) 👍
@clue
Copy link
Member

clue commented Jan 3, 2021

@cobolfoo Thanks for filing this PR!

Are you aware of #102? There used to be a setData() method that has been removed in favor of binding arbitrary variables to closures.

From my personal experience, this is something has worked much better than assigning variables through a single "data" variable. I've build dozens of complex and simple projects with this and feel comfortable saying that I very much prefer this way and haven't encountered any issues doing so.

That being said, I'm open for discussion and I'd like to learn more about the problem you're seeing. Perhaps you can gist why you think this could be beneficial?

@clue
Copy link
Member

clue commented Apr 5, 2021

I'm closing this for now as it hasn't received any input in a while and I believe this has been answered. Please come back with more details if this persists and we can reopen this 👍

@clue clue closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants