-
-
Notifications
You must be signed in to change notification settings - Fork 130
Fix for PHP 7 fatal error on duplicate parameter names in closures #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb7dc83
to
3bc352a
Compare
The build failed on PHP 5.5 because the composer.json requires PHPUnit version that requires PHP 5.6. |
That is interesting because the 5.4 build didn't fail. We don't specify phpunit in composer.json, the phpunit versions are supplied by travis |
The changes LGTM and make perfect sense 👍 Though I'm a bit surprised, has #27 been solved yet? Afaict nobody has managed to build the required extensions, so this code will not actually run? (Only the |
Event 2.0 has been released with full PHP7 support. What is needed to get this to be merged? |
We are already using PECL event 2.0 extension with PHP 7.0.3 with this patch and everything works fine. |
@ondrejmirtes I'm busy patching our local install. Wondering when this will end up in a event-loop release. |
I will contact ReactPHP maintainers in order to ask them what can we do to bring ReactPHP up to speed. |
#45 includes this fix and adds also tests for php 7. |
Merged in via #45 |
PHP 7 does not like duplicate parameter names: https://3v4l.org/usQhl