Lock Travis distro so new defaults will not break the build #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Aug 7, 2017
| matrix: | ||
| allow_failures: | ||
| - php: hhvm | ||
| - php: nightly |
There was a problem hiding this comment.
What's the reason for allowing failures for hhvm and nightly now?
There was a problem hiding this comment.
The short version is that HHVM builds on Travis repeatedly broke in the past and needed updates despite otherwise working perfectly fine and nightly builds can't really be guaranteed in the future as they have the potential of breaking once PHP 8 or PHP 9 is out.
Also, this is now in line with all other components 👍
See also reactphp/http-client#105, reactphp/socket#109 and reactphp/dns#56
jsor
approved these changes
Aug 7, 2017
WyriHaximus
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis is in the process of upgrading the base distro (https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming) and despite all PRs currently being "green", may start to mark the current master as broken. Unlike reactphp/stream#110 this project is not affected by Travis dropping support for older versions of PHP.
Originally from clue/reactphp-connection-manager-extra#24