is brownfield Android Fragment loading supported?

[francois-pasquier]

Trying to load a react native fragment with the new architecture results in the error below.

This is with the latest 0.74.1 react native template with a minor modification of loading a new Activity containing the following fragment loading code:

            val reactNativeFragment = ReactFragment.Builder()
                .setComponentName("HelloRN")
                .setFabricEnabled(true)
                .build()
            childFragmentManager
                .beginTransaction()
                .add(R.id.reactNativeFragment, reactNativeFragment)
                .commit()

java.lang.NullPointerException: Attempt to invoke interface method 'com.facebook.react.interfaces.fabric.ReactSurface com.facebook.react.ReactHost.createSurface(android.content.Context, java.lang.String, android.os.Bundle)' on a null object reference
                                                                                                    	at com.facebook.react.ReactDelegate.loadApp(ReactDelegate.java:281)
                                                                                                    	at com.facebook.react.ReactDelegate.loadApp(ReactDelegate.java:273)
                                                                                                    	at com.facebook.react.ReactFragment.onCreateView(ReactFragment.java:95)
                                                                                                    	at androidx.fragment.app.Fragment.performCreateView(Fragment.java:3114)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:557)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:272)
                                                                                                    	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1943)
                                                                                                    	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1839)
                                                                                                    	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
                                                                                                    	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:958)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:205)
                                                                                                    	at android.os.Looper.loop(Looper.java:294)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8176)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

[gmantuanrosa]

I'm facing the same issue when enabling the new architecture on 0.74.5

[cortinico]

@francois-pasquier we do support custom Fragments with the New Architecture. Could you create a small reproducer using https://github.com/react-native-community/reproducer-react-native and we can look into (this feels more like a bug that should probably be reported on https://github.com/facebook/react-native/issues als)

[gmantuanrosa]

I'm in the process of creating a reproducible repo. I will post here soon

[gmantuanrosa]

@cortinico After some time trying to reproduce what we currently have in a simpler way, here it is the reproducible repository: https://github.com/gmantuanrosa/brownfield-rn-fragment

I basically created a new Android project with compose, then I added a Host Navigation with a Bottom Tab with two Fragments, one being Native and the other instantiating React Native.

The native one is the initial route, so it should display fine, as soon as you move to the other tab the App crashes with:

E  FATAL EXCEPTION: main
          Process: com.example.composereactnativeapp, PID: 15959
          java.lang.NullPointerException: Attempt to invoke interface method 'com.facebook.react.interfaces.fabric.ReactSurface com.facebook.react.ReactHost.createSurface(android.content.Context, java.lang.String, android.os.Bundle)' on a null object reference
           at com.facebook.react.ReactDelegate.loadApp(ReactDelegate.java:283)
           at com.facebook.react.ReactDelegate.loadApp(ReactDelegate.java:275)
           at com.facebook.react.ReactFragment.onCreateView(ReactFragment.java:95)
           at androidx.fragment.app.Fragment.performCreateView(Fragment.java:3119)
           at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:577)
           at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286)
           at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2164)
           at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2059)
           at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
           at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3277)
           at androidx.fragment.app.FragmentManager.dispatchViewCreated(FragmentManager.java:3180)
           at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3153)
           at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:608)
           at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286)
           at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2164)
           at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2059)
           at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
           at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:702)
           at android.os.Handler.handleCallback(Handler.java:938)
           at android.os.Handler.dispatchMessage(Handler.java:99)
           at android.os.Looper.loopOnce(Looper.java:201)
           at android.os.Looper.loop(Looper.java:288)
           at android.app.ActivityThread.main(ActivityThread.java:7870)
           at java.lang.reflect.Method.invoke(Native Method)
           at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
           at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

I run the project through Android Studio on a physical device, so after building the project and run adb reverse tcp:8081 tcp:8081 I then go to the React Native project and start the server

[gmantuanrosa]

btw, I am building using React Native 0.75.3

[gmantuanrosa]

Any news on this issue?

[cortinico]

Following up here. @gmantuanrosa opened an issue here:

• Brownfield app crashes when using ReactFragment on new architecture facebook/react-native#46566 (comment)

We realized that ReactFragment had a bug and was not properly working with New Architecture. The fix for it is forthcoming and will be included in 0.76.