autoscaler: update storageautoscaler design doc #3105
Conversation
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
06ec85a to
5ba07df
Compare
|
/assign @travisn @BlaineEXE @leelavg @nb-ohad |
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
5ba07df to
f7f9c26
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parth-gr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
f7f9c26 to
80f27b4
Compare
docs/design/storage-auto-scale.md
Outdated
|
|
||
| 3) Check if the expansion is in progress: | ||
|
|
||
| 1) Load the actualOsdCount and actualOsdSize from the syncMap. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Agreed, seems like the scraper has no reason to query the actual osd count and size. All the scraper is concerned with, is whether it appears the cluster is getting full.
So it seems to me the controller should just directly query prometheus for the osd count and size.
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
80f27b4 to
6323f07
Compare
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
6323f07 to
1ae5b28
Compare
Currrently the controller was dependent on reading cr status, update the controller to not depend on cr status Signed-off-by: parth-gr <[email protected]>
parth-gr
force-pushed
the
update-autoscaler-design
branch
from
1ae5b28 to
7592e48
Compare
|
@parth-gr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Currrently the controller was dependednt on reading cr status, update the design so controller to not depend on cr status