Update gopls and kubedock #749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kwon <[email protected]>
dkwon17
commented
Apr 4, 2025
| # https://registry.access.redhat.com/ubi9/go-toolset | ||
| FROM registry.redhat.io/ubi9/go-toolset:9.5-1743582279 as go-builder | ||
| #@follow_tag(registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:rhel_9_1.23) | ||
| FROM registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.23.6-202503041452.g6c23478.el9 AS go-builder |
Signed-off-by: David Kwon <[email protected]>
dkwon17
commented
Apr 4, 2025
| @@ -29,19 +28,19 @@ RUN \ | |||
| echo 'replace golang.org/x/tools => ../' >> go.mod && \ | |||
| # build gopls application with dependencies resolved by Cachito (which are also resolved for 'tools' dependency) | |||
| source $REMOTE_SOURCES_DIR/gopls/cachito.env && \ | |||
| GO111MODULE=on go build -o gopls && \ | |||
| ./gopls version && \ | |||
| GO111MODULE=on go build -mod=mod -o gopls && \ | |||
There was a problem hiding this comment.
This was added because there was an error with gomod vendoring when:
remote_sources_version: 2
in container.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates updates gopls to 0.18.1 and kubedock to 0.18.1.