Skip to content

feat: expose gitops operator metrics to openshift-monitoring stack #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

jaideepr97
Copy link
Contributor

@jaideepr97 jaideepr97 commented Jul 7, 2023

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Note: this PR has a dependency on #556

This PR contains all the changes required to make gitops-operator metrics accessible through the openshift-monitoring stack and viewable within the Openshift console. The included changes are as follows:

  • Change gitops-operator's default namespace to openshift-gitops-operator and enable cluster monitoring out of the box
  • Add kube-rbac-proxy container to the operator deployment to protect the operator's /metrics endpoint
  • Add the following manifests to the bundle to allow openshift-monitoring stack to pick up the metrics:
    • metrics service
    • service monitor
    • role and rolebinding to allow openshift-monitoring to access operator's metrics endpoint

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  • Build an operator containing these manifest changes
  • install the operator on a cluster
  • go the admin > observe > metrics tab of the console
  • confirm you are able to query active_argocd_instances_total and see the graph for it

@openshift-ci openshift-ci bot requested review from chetan-rns and wtam2018 July 7, 2023 21:50
@jaideepr97 jaideepr97 force-pushed the operator-metrics-2 branch from 4e3ef4f to 7938e12 Compare July 7, 2023 22:03
Signed-off-by: Jaideep Rao <[email protected]>
@iam-veeramalla
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@jaideepr97
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Sep 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

New changes are detected. LGTM label has been removed.

Signed-off-by: Jaideep Rao <[email protected]>
@jaideepr97
Copy link
Contributor Author

/retest

1 similar comment
@varshab1210
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

@jaideepr97: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-kuttl-sequential 542f688 link true /test v4.10-kuttl-sequential
ci/prow/v4.11-kuttl-sequential 542f688 link true /test v4.11-kuttl-sequential
ci/prow/v4.11-kuttl-parallel 542f688 link true /test v4.11-kuttl-parallel
ci/prow/v4.10-kuttl-parallel 542f688 link true /test v4.10-kuttl-parallel
ci/prow/v4.14-kuttl-sequential-periodic 542f688 link true /test v4.14-kuttl-sequential-periodic
ci/prow/v4.14-kuttl-parallel a0c3ada link true /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential a0c3ada link true /test v4.14-kuttl-sequential
ci/prow/v4.13-e2e ea5e579 link true /test v4.13-e2e
ci/prow/v4.13-kuttl-sequential ea5e579 link true /test v4.13-kuttl-sequential
ci/prow/v4.12-kuttl-sequential ea5e579 link true /test v4.12-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iam-veeramalla iam-veeramalla merged commit 2989425 into redhat-developer:master Sep 11, 2023
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…ics-2

feat: expose gitops operator metrics to openshift-monitoring stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants