Add OpenShift Dashboards for GitOps #589
Conversation
|
Hi @gnunn1. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @gnunn1, I tested this out and it works great! |
|
Moving dashboards outside of controllers doesn't work for me, there are some limitations around go embed with respect to where the content is located.
https://www.iamyadav.com/blogs/a-guide-to-embedding-static-files-in-go |
|
I have made the requested changes plus added the ability for it to update the dashboard configmap if the data element doesn't match the expectation. |
…ion and not just create
| reqLogger.Error(err, "Error creating a new dashboard", | ||
| "Namespace", dashboard.Namespace, "Name", dashboard.Name) | ||
| // Should we return an error or continue with other dashboards? | ||
| return err |
There was a problem hiding this comment.
I think we should continue with other dashboards here, unless they only make sense in context of each other.
If that is not that case, and there is value in viewing each dashboard independently, we should not return error here
same for line 332 as well
|
/ok-to-test |
|
@gnunn1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaideepr97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Provision dashboards for OpenShift Console * Create constant for dashboards folder path * Add unit test * Improve error message when dashboard namespace is not available * Remove redis graph due to upstream bug not exposing stats * Update function name and message as per Jaideep's review comments * Reconcile dashboards if data in configmap changes * Change name to reconcileDashboards since we are now doing reconciliation and not just create * Continue processing dashboards if error occurs instead of stopping * Continue processing dashboards if new dashboard creation fails --------- Co-authored-by: William Tam <[email protected]>
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This provisions a set of dashboards in the OpenShift console (Observer > Dashboards) to provide monitoring for GitOps. These dashboards are based on the upstream Argo CD dashboards but have been modified to work with the OpenShift console which has a reduced feature set compared to Grafana.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-1767
Fixes #?
GITOPS-1767
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Install the GitOps Operator on an OpenShift cluster and then navigate to Observe > Dashboards in the console. In the dropdown list of dashboards note that three new dashboards are now available: