Skip to content

Change installation namespace #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Conversation

varshab1210
Copy link
Member

@varshab1210 varshab1210 commented Sep 6, 2023

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

To avoid failure in openshift/release#43023

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
@varshab1210 varshab1210 force-pushed the change-installation-namespace branch from 7ec84d2 to d6c132d Compare September 6, 2023 14:58
@varshab1210 varshab1210 marked this pull request as ready for review September 6, 2023 14:58
@openshift-ci openshift-ci bot requested review from ciiay and wtam2018 September 6, 2023 14:58
jaideepr97
jaideepr97 previously approved these changes Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

New changes are detected. LGTM label has been removed.

@varshab1210
Copy link
Member Author

Hi @jaideepr97 @wtam2018
Could you please merge this PR to make the CI stable again (openshift/release#43023 needs to be merged and for he CI checks to pass there this PR needs to be merged)

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

@varshab1210: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.13-kuttl-parallel fc70971 link true /test v4.13-kuttl-parallel
ci/prow/v4.13-kuttl-sequential fc70971 link true /test v4.13-kuttl-sequential
ci/prow/v4.12-kuttl-sequential fc70971 link true /test v4.12-kuttl-sequential
ci/prow/v4.12-kuttl-parallel fc70971 link true /test v4.12-kuttl-parallel
ci/prow/v4.14-kuttl-parallel fc70971 link true /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential fc70971 link true /test v4.14-kuttl-sequential
ci/prow/v4.14-e2e fc70971 link true /test v4.14-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jaideepr97 jaideepr97 added the lgtm label Sep 7, 2023
Copy link
Contributor

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@iam-veeramalla iam-veeramalla merged commit 4e53510 into master Sep 8, 2023
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…installation-namespace

Change installation namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants