chore: update kube-rbac-proxy args to disable http2 #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: varshab1210 <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
This reverts commit 6cff7f8. Previous changes work as expected. Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Jaideep Rao <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
…#614) * update to go 1.20; disable http2 for servers; upgrade k8s packages Signed-off-by: Jaideep Rao <[email protected]> * remove secure serving option for metrics Signed-off-by: Jaideep Rao <[email protected]> * Changing go version for CI Signed-off-by: varshab1210 <[email protected]> * Disable http/2 on webhook server Signed-off-by: Siddhesh Ghadi <[email protected]> * Revert "Disable http/2 on webhook server" This reverts commit 6cff7f8. Previous changes work as expected. Signed-off-by: Siddhesh Ghadi <[email protected]> * consume keycloak segmentation fault fix Signed-off-by: Jaideep Rao <[email protected]> * update kube-rbac-proxy image Signed-off-by: Jaideep Rao <[email protected]> * undo makefile changes Signed-off-by: Jaideep Rao <[email protected]> * disable http2 for kube-rbac-proxy Signed-off-by: Jaideep Rao <[email protected]> * switch to floating tag for kube-rbac-proxy image Signed-off-by: Jaideep Rao <[email protected]> * consume argocd-operator commit Signed-off-by: Jaideep Rao <[email protected]> * remove http2 disable command line arg Signed-off-by: Jaideep Rao <[email protected]> * disable http2 in kube-rbac-proxy container Signed-off-by: Jaideep Rao <[email protected]> --------- Signed-off-by: Jaideep Rao <[email protected]> Signed-off-by: varshab1210 <[email protected]> Signed-off-by: Siddhesh Ghadi <[email protected]> Co-authored-by: varshab1210 <[email protected]> Co-authored-by: Siddhesh Ghadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
disables http2 for kube-rbac-proxy container after picking up patched version of the downstream kube-rbac-proxy image
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: