Skip to content

Minor fixes to update-rollouts-manager script #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Jul 16, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind enhancement

What does this PR do / why we need it:

Minor tweaks to improve the script which is used to upgrade the rollouts-manager dependency in gitops-operator repo

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jul 16, 2024
Copy link

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@Rizwana777 Rizwana777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jgwest
Copy link
Collaborator Author

jgwest commented Jul 19, 2024

Thanks @Rizwana777!

@jgwest jgwest merged commit 2703166 into redhat-developer:master Jul 19, 2024
17 of 18 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants