Skip to content

implemented 'Open Dashboard' action (#617) #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

implemented 'Open Dashboard' action (#617) #627

merged 1 commit into from
Jul 12, 2023

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Jul 8, 2023 •
edited
Loading

fixes #617

@adietish adietish changed the title Issue 617 implemented 'Open Dashboard' action (#617) Jul 8, 2023
@adietish adietish force-pushed the issue-617 branch 10 times, most recently from 8bed447 to 1063964 Compare July 11, 2023 17:00
@adietish adietish requested a review from datho7561 July 11, 2023 18:03
@adietish adietish self-assigned this Jul 11, 2023
@adietish adietish marked this pull request as ready for review July 11, 2023 18:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

datho7561
datho7561 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I tried it out with:

  • crc OpenShift
  • minikube
  • crc microshift

OpenShift and minikube worked well. MicroShift doesn't come with a dashboard, so when I tried it out, there was an error popup, as expected.

@adietish adietish merged commit 54ee800 into redhat-developer:main Jul 12, 2023
@adietish adietish deleted the issue-617 branch July 12, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want to be able to open the web console to my kubernetes or openshift cluster
2 participants
@adietish @datho7561