Skip to content

use ActionPlaces.TOOLWINDOW_POPUP for resource tree popup menu (#705) #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

adietish
Copy link
Collaborator

fixes #705

@adietish adietish self-assigned this Jan 12, 2024
@adietish adietish requested a review from olkornii January 12, 2024 14:15
@adietish
Copy link
Collaborator Author

@olkornii please review

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olkornii
Copy link
Collaborator

olkornii commented Jan 15, 2024

Tested with:
minikube v1.31.0, kubernetes v1.29.0
Intellij IDEA 2022.1
@adietish Hi, I've tried issue-705 branch. There is no Popup warning anymore. But I've noticed another warnings.
Steps:

  1. open Kubernetes tab
  2. expand "Namespaces"
  3. right click on some namespace
  4. select "Use namespace"
  5. warning appears:
    024-01-15 11:46:57,886 [ 69368] WARN - i.f.k.c.r.Readiness - Namespace is not a Readiable resource. It needs to be one of [Node, Deployment, ReplicaSet, StatefulSet, Pod, ReplicationController]

Copy link
Collaborator

@olkornii olkornii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning is gone. See last comment.

@adietish
Copy link
Collaborator Author

@olkornii: the warning that you noticed is not related. It is caused by the kubernetes client: fabric8io/kubernetes-client#2672. It points us to bump the kubernetes-client at some point.

@adietish adietish merged commit 24b0698 into redhat-developer:main Jan 15, 2024
@adietish adietish deleted the issue-705 branch January 15, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Please do not use ActionPlaces.UNKNOWN or the empty place." warning after right click on namespace
2 participants