Skip to content

fix: use #create/replace not #patch when resource has managed fields (#755) #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

fix: use #create/replace not #patch when resource has managed fields (#755) #756

merged 1 commit into from
May 6, 2024

Conversation

adietish
Copy link
Collaborator

fixes #755

@adietish adietish self-assigned this Apr 29, 2024
@adietish adietish changed the title use #create/replace not #patch when resource has managed fields (#755) fix: use #create/replace not #patch when resource has managed fields (#755) Apr 29, 2024
@adietish adietish force-pushed the issue-755 branch 9 times, most recently from 996ecd4 to 40aa573 Compare April 30, 2024 12:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 30, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adietish adietish requested a review from olkornii April 30, 2024 13:27
@adietish adietish marked this pull request as ready for review April 30, 2024 13:27
@adietish
Copy link
Collaborator Author

@olkornii please review.

olkornii
olkornii approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@olkornii olkornii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with minikube on Fedora :) Thank you.

@adietish adietish merged commit e431b02 into redhat-developer:main May 6, 2024
12 of 13 checks passed
@adietish adietish deleted the issue-755 branch May 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olkornii olkornii olkornii approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create or update resource with managed fields
2 participants
@adietish @olkornii