fix: allow to edit secrets/configmaps in multi-resource yaml documents (#852) #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
force-pushed
the
issue-852
branch
6 times, most recently
from
a8e288d to
9b072ad
Compare
adietish
changed the title
adietish
changed the title
|
multi-resource json files are not supported yet. See #855 |
Signed-off-by: Andre Dietisheim <[email protected]>
|
adietish
requested review from
msivasubramaniaan
and removed request for
sbouchet
|
@msivasubramaniaan: glad that your testing result was +1. Can you please approve the PR so that I can merge it? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #852
fixes #854
depends on redhat-developer/intellij-common#272
depends on redhat-developer/intellij-common#273