Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: texts in notifications for creating & created (#714,#716) #720

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: texts in notifications for creating & created (#714,#716) #720

merged 1 commit into from
Feb 27, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Feb 26, 2024 •
edited
Loading

fixes #714
fixes #716

@adietish adietish self-assigned this Feb 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish marked this pull request as ready for review February 26, 2024 14:51
@openshift-ci openshift-ci bot requested a review from sbouchet February 26, 2024 14:51
@adietish adietish changed the title fix: texts in notifications for creating & created (#714,#715) fix: texts in notifications for creating & created (#714,#716) Feb 26, 2024
This was referenced Feb 26, 2024
Closed
Closed
adietish added a commit to adietish/intellij-openshift-connector that referenced this pull request Feb 26, 2024
@adietish
fix: show 'missing project' - not log in - when current is inexistant (…
3a7aa2a 
…redhat-developer#715, redhat-developer#720)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish requested a review from martinszuc February 27, 2024 08:28
adietish added a commit to adietish/intellij-openshift-connector that referenced this pull request Feb 27, 2024
@adietish
fix: show 'missing project' - not log in - when current is inexistant (…
6eeb112 
…redhat-developer#715, redhat-developer#720)

Signed-off-by: Andre Dietisheim <[email protected]>
martinszuc
martinszuc approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@martinszuc martinszuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good to me!

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2024
sbouchet
sbouchet approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinszuc, sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sbouchet
Copy link
Collaborator

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 290172f into redhat-developer:main Feb 27, 2024
@adietish adietish deleted the issue-714 branch February 27, 2024 13:10
adietish added a commit to adietish/intellij-openshift-connector that referenced this pull request Feb 27, 2024
@adietish
fix: show 'missing project' - not log in - when current is inexistant (…
dcf2500 
…redhat-developer#715, redhat-developer#720)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-openshift-connector that referenced this pull request Feb 27, 2024
@adietish
fix: show 'missing project' - not log in - when current is inexistant (…
eac59a6 
…redhat-developer#715, redhat-developer#720)

Signed-off-by: Andre Dietisheim <[email protected]>
openshift-merge-bot bot pushed a commit that referenced this pull request Feb 27, 2024
@adietish
fix: show 'missing project' - not log in - when current is inexistant (…
ba50305 
…#715, #720) (#722)

Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbouchet sbouchet sbouchet approved these changes

@martinszuc martinszuc martinszuc approved these changes

Assignees

@adietish adietish

@sbouchet sbouchet

@martinszuc martinszuc

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Create new project notification shows wrong project name bug: Missing space in "Project __ successfully created" notification
3 participants
@adietish @sbouchet @martinszuc