fix: start dev on podman does not work if odo can't retrieve podman status #773

sbouchet · 2024-04-04T16:07:27Z

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #637

How to test changes?

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2024-04-09T13:37:31Z

...in/java/org/jboss/tools/intellij/openshift/actions/component/DevOnPodmanComponentAction.java

+                return;
+            }
+            try {
+                e.getPresentation().setEnabled(odo.checkPodman());


Actual fix is here

Is this the fix for the following when using IU-2023.3?

Screen.Recording.2024-04-09.at.16.47.56.mov

com.intellij.diagnostic.PluginException: 316 ms to call on EDT DevOnPodmanComponentAction#Update@MainMenu (org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction). Revise AnAction.getActionUpdateThread property [Plugin: org.jboss.tools.intellij.openshift] at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23) at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:89) at com.intellij.openapi.actionSystem.impl.ActionUpdater.computeOnEdt(ActionUpdater.kt:223) at com.intellij.openapi.actionSystem.impl.ActionUpdater.access$computeOnEdt(ActionUpdater.kt:71) at com.intellij.openapi.actionSystem.impl.ActionUpdater$computeOnEdt$1.invokeSuspend(ActionUpdater.kt) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108) at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115) at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684) Suppressed: java.lang.Throwable: EDT-trace-at-264-ms (4/5) at java.base@17.0.9/java.lang.Object.wait(Native Method) at java.base@17.0.9/java.lang.Object.wait(Object.java:338) at java.base@17.0.9/java.lang.ProcessImpl.waitFor(ProcessImpl.java:434) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:323) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:253) at com.redhat.devtools.intellij.common.utils.ExecHelper.executeWithResult(ExecHelper.java:258) at org.jboss.tools.intellij.openshift.utils.odo.OdoCli.execute(OdoCli.java:158) at org.jboss.tools.intellij.openshift.utils.odo.OdoCli.execute(OdoCli.java:176) at org.jboss.tools.intellij.openshift.utils.odo.OdoCli.checkPodman(OdoCli.java:814) at org.jboss.tools.intellij.openshift.tree.application.ApplicationRootNodeOdo.checkPodman(ApplicationRootNodeOdo.java:360) at org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction.update(DevOnPodmanComponentAction.java:59) at com.intellij.openapi.actionSystem.ex.ActionUtil.lambda$performDumbAwareUpdate$0(ActionUtil.java:164) at com.intellij.openapi.actionSystem.ex.ActionUtil$$Lambda$1521/0x000000f000d62bd0.run(Unknown Source) at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareUpdate(ActionUtil.java:187) at com.intellij.openapi.actionSystem.impl.ActionUpdaterKt.doUpdate(ActionUpdater.kt:696) at com.intellij.openapi.actionSystem.impl.ActionUpdaterKt.access$doUpdate(ActionUpdater.kt:1) at com.intellij.openapi.actionSystem.impl.ActionUpdater$updateActionReal$success$1.invoke(ActionUpdater.kt:110) at com.intellij.openapi.actionSystem.impl.ActionUpdater$updateActionReal$success$1.invoke(ActionUpdater.kt:109) at com.intellij.openapi.actionSystem.impl.ActionUpdater$callAction$4.invoke(ActionUpdater.kt:178) at com.intellij.openapi.actionSystem.impl.ActionUpdater$computeOnEdt$2.invoke(ActionUpdater.kt:204) at com.intellij.openapi.actionSystem.impl.ActionUpdater$computeOnEdt$deferred$1$1.invoke(ActionUpdater.kt:468) at com.intellij.openapi.progress.CoroutinesKt.blockingContextInner(coroutines.kt:321) at com.intellij.openapi.progress.CoroutinesKt.access$blockingContextInner(coroutines.kt:1) at com.intellij.openapi.progress.CoroutinesKt$blockingContext$2.invokeSuspend(coroutines.kt:198) at com.intellij.openapi.progress.CoroutinesKt$blockingContext$2.invoke(coroutines.kt) at com.intellij.openapi.progress.CoroutinesKt$blockingContext$2.invoke(coroutines.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:264) at com.intellij.openapi.progress.CoroutinesKt.blockingContext(coroutines.kt:197) at com.intellij.openapi.actionSystem.impl.ActionUpdater$computeOnEdt$deferred$1.invokeSuspend(ActionUpdater.kt:467) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source) at com.intellij.openapi.actionSystem.impl.UtilsKt$runBlockingForActionExpand$1.invoke(Utils.kt:1108) at com.intellij.openapi.actionSystem.impl.UtilsKt$runBlockingForActionExpand$1.invoke(Utils.kt:1105) at com.intellij.openapi.progress.ContextKt.prepareThreadContext(context.kt:86) at com.intellij.openapi.actionSystem.impl.Utils.expandActionGroupImpl(Utils.kt:1130) at com.intellij.openapi.actionSystem.impl.Utils.fillMenu$intellij_platform_ide_impl(Utils.kt:394) at com.intellij.openapi.actionSystem.impl.Utils.fillPopupMenu(Utils.kt:366) at com.intellij.openapi.actionSystem.impl.ActionPopupMenuImpl$MyMenu.updateChildren(ActionPopupMenuImpl.java:174) at com.intellij.openapi.actionSystem.impl.ActionPopupMenuImpl$MyMenu.show(ActionPopupMenuImpl.java:124) at com.intellij.ui.PopupHandler$2.invokePopup(PopupHandler.java:142) at com.intellij.ui.PopupHandler.mousePressed(PopupHandler.java:47) at java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:288) at java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:287) at java.desktop/java.awt.Component.processMouseEvent(Component.java:6654) at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3385) at com.intellij.ui.treeStructure.Tree.processMouseEvent(Tree.java:434) at java.desktop/java.awt.Component.processEvent(Component.java:6422) at java.desktop/java.awt.Container.processEvent(Container.java:2266) at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5027) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4855) at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4969) at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4580) at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4524) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310) at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2809) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4855) at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:794) at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739) at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:733) at java.base@17.0.9/java.security.AccessController.executePrivileged(AccessController.java:776) at java.base@17.0.9/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base@17.0.9/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.base@17.0.9/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:766) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:764) at java.base@17.0.9/java.security.AccessController.executePrivileged(AccessController.java:776) at java.base@17.0.9/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base@17.0.9/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:763) at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.kt:695) at com.intellij.ide.IdeEventQueue.dispatchMouseEvent(IdeEventQueue.kt:635) at com.intellij.ide.IdeEventQueue._dispatchEvent$lambda$10(IdeEventQueue.kt:580) at com.intellij.ide.IdeEventQueue$$Lambda$2172/0x000000f00144bba8.run(Unknown Source) at com.intellij.openapi.application.impl.RwLockHolder.runWithEnabledImplicitRead(RwLockHolder.kt:75) at com.intellij.openapi.application.impl.RwLockHolder.runWithImplicitRead(RwLockHolder.kt:67) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:580) at com.intellij.ide.IdeEventQueue.access$_dispatchEvent(IdeEventQueue.kt:72) at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:355) at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:354) at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:793) at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:354) at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:349) at com.intellij.ide.IdeEventQueueKt.performActivity$lambda$1(IdeEventQueue.kt:1014) at com.intellij.ide.IdeEventQueueKt$$Lambda$1336/0x000000f000b36dd0.run(Unknown Source) at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:114) at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1014) at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda$7(IdeEventQueue.kt:349) at com.intellij.ide.IdeEventQueue$$Lambda$1329/0x000000f000b335c0.run(Unknown Source) at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:848) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:391) at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207) at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128) at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105) at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)

adietish

works for me. LGTM.
I would have preferred to have the reformatting in a separate PR though because it's almost impossible to review 4000+ lines.

adietish

Imho we should fix the fatal IDE error that I can reproduce in IU-2023.3 (see #773 (comment))

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2024-04-11T14:16:00Z

works for me. LGTM. I would have preferred to have the reformatting in a separate PR though because it's almost impossible to review 4000+ lines.

Yes, totally agree. as tests are failling, i'm going to a rabbit hole trying to refactor it rather than fixing it and focus on the actual isssue.

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2024-04-12T09:39:52Z

src/main/java/org/jboss/tools/intellij/openshift/actions/component/FeatureComponentAction.java

@@ -59,10 +59,6 @@ public void update(AnActionEvent e) {
            }
            ComponentNode componentNode = (ComponentNode) node;
            Component component = componentNode.getComponent();
-            Odo odo = componentNode.getRoot().getOdo().getNow(null);


removed because it causes slow actions updates.

sbouchet · 2024-04-12T09:42:54Z

src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java

@@ -459,16 +459,18 @@ public List<URL> listURLs(String context) throws IOException {
  @Override
  public ComponentInfo getComponentInfo(String project, String component, String path,
                                        ComponentKind kind) throws IOException {
+    boolean isPodmanPresent = !execute(command, envVars, "version").contains("unable to fetch the podman client version");


podman check is now here, added as componentInfo status. This is done when loading tree component where the debug podman action resisdes.

sbouchet · 2024-04-12T09:43:58Z

@adietish please review.

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

sonarqubecloud · 2024-04-12T13:22:37Z

Quality Gate failed

Failed conditions
31.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sbouchet · 2024-04-12T13:43:19Z

/override ci/prow/e2e-openshift

openshift-ci · 2024-04-12T13:43:24Z

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adietish

Other than maybe adding a unit test for the action, LGTM. Works for me.

adietish · 2024-04-12T13:51:21Z

src/test/java/org/jboss/tools/intellij/openshift/utils/odo/JsonParserTest.java

+    assertTrue(componentInfo.getSupportedFeatures().contains(ComponentFeature.Mode.DEV_MODE));
+    assertEquals("Go", componentInfo.getComponentTypeName());
+    assertEquals("Go", componentInfo.getLanguage());
+  }



Maybe you could add a unit test in DevOnPodmanComponentActionTest testing enablement when podman is present/not present?

openshift-ci · 2024-04-12T13:53:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adietish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix: start dev on podman does not work if odo can't retrieve podman s…

f71838c

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

openshift-ci bot requested a review from adietish April 4, 2024 16:07

sbouchet added 3 commits April 4, 2024 18:09

Merge branch 'main' into issue-637

7afbf37

fix: start dev on podman does not work if odo can't retrieve podman s…

76b11fd

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

fix: start dev on podman does not work if odo can't retrieve podman s…

4c93a4d

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet commented Apr 9, 2024

View reviewed changes

adietish approved these changes Apr 9, 2024

View reviewed changes

openshift-ci bot assigned adietish Apr 9, 2024

openshift-ci bot added lgtm approved labels Apr 9, 2024

adietish suggested changes Apr 9, 2024

View reviewed changes

openshift-ci bot removed lgtm approved labels Apr 9, 2024

Merge branch 'main' into issue-637

cbfe8de

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet mentioned this pull request Apr 11, 2024

Refactor integration tests #779

Closed

sbouchet added 5 commits April 12, 2024 10:04

fix: start dev on podman does not work if odo can't retrieve podman s…

9e23bda

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

fix: start dev on podman does not work if odo can't retrieve podman s…

9e3b62e

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

fix: start dev on podman does not work if odo can't retrieve podman s…

ade3bc5

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

fix: start dev on podman does not work if odo can't retrieve podman s…

227b1e0

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

fix: start dev on podman does not work if odo can't retrieve podman s…

cacfa42

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet commented Apr 12, 2024

View reviewed changes

sbouchet requested a review from adietish April 12, 2024 09:43

sbouchet added 3 commits April 12, 2024 11:44

Merge branch 'main' into issue-637

4561ce2

Merge branch 'main' into issue-637

69bea0d

fix: start dev on podman does not work if odo can't retrieve podman s…

4232edb

…tatus Signed-off-by: Stephane Bouchet <[email protected]>

adietish approved these changes Apr 12, 2024

View reviewed changes

openshift-ci bot added the lgtm label Apr 12, 2024

openshift-ci bot added the approved label Apr 12, 2024

openshift-merge-bot bot merged commit 0bd539a into redhat-developer:main Apr 12, 2024

sbouchet mentioned this pull request Apr 12, 2024

Add a unit test in DevOnPodmanComponentActionTest #782

Closed

sbouchet deleted the issue-637 branch April 12, 2024 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: start dev on podman does not work if odo can't retrieve podman status #773

fix: start dev on podman does not work if odo can't retrieve podman status #773

Uh oh!

sbouchet commented Apr 4, 2024

Uh oh!

sbouchet Apr 9, 2024

Uh oh!

adietish Apr 9, 2024 •

edited

Loading

Uh oh!

sbouchet Apr 11, 2024

Uh oh!

adietish left a comment

Uh oh!

adietish left a comment •

edited

Loading

Uh oh!

sbouchet commented Apr 11, 2024

Uh oh!

sbouchet Apr 12, 2024

Uh oh!

sbouchet Apr 12, 2024

Uh oh!

sbouchet commented Apr 12, 2024

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Uh oh!

sbouchet commented Apr 12, 2024

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

adietish left a comment

Uh oh!

adietish Apr 12, 2024

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

Uh oh!

fix: start dev on podman does not work if odo can't retrieve podman status #773

fix: start dev on podman does not work if odo can't retrieve podman status #773

Uh oh!

Conversation

sbouchet commented Apr 4, 2024

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

How to test changes?

Uh oh!

sbouchet Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

adietish Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbouchet Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

adietish left a comment

Choose a reason for hiding this comment

Uh oh!

adietish left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbouchet commented Apr 11, 2024

Uh oh!

sbouchet Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

sbouchet Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

sbouchet commented Apr 12, 2024

Uh oh!

sonarqubecloud bot commented Apr 12, 2024

Quality Gate failed

Uh oh!

sbouchet commented Apr 12, 2024

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

adietish left a comment

Choose a reason for hiding this comment

Uh oh!

adietish Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

Uh oh!

adietish Apr 9, 2024 •

edited

Loading

adietish left a comment •

edited

Loading