Skip to content

fix: readme: removed cdk, minishift. renamed CRC to OpenShift Local (… #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Oct 8, 2024

fixes #909

@adietish adietish requested a review from mohitsuman October 8, 2024 10:05
@adietish adietish self-assigned this Oct 8, 2024
@openshift-ci openshift-ci bot requested a review from sbouchet October 8, 2024 10:05
Copy link

sonarqubecloud bot commented Oct 8, 2024

@adietish
Copy link
Contributor Author

adietish commented Oct 8, 2024

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Oct 8, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

@mohitsuman: please review

Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 10, 2024

@adietish: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Conventional Commits PR Check / Cluster Integration UI Tests Report

Only the following failed contexts/checkruns were expected:

  • Aggregated Test Report
  • Cluster Integration UI Tests Report
  • Public Integration UI Tests Report
  • ci/prow/e2e-openshift
  • license/snyk (Developer - IDE Extensions)
  • pull-ci-redhat-developer-intellij-openshift-connector-main-e2e-openshift
  • security/snyk (Developer - IDE Extensions)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Conventional Commits PR Check / Cluster Integration UI Tests Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

/override "Aggregated Test Report"

Copy link

openshift-ci bot commented Oct 10, 2024

@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report

In response to this:

/override "Aggregated Test Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

/override "Cluster Integration UI Tests Report"

Copy link

openshift-ci bot commented Oct 10, 2024

@adietish: Overrode contexts on behalf of adietish: Cluster Integration UI Tests Report

In response to this:

/override "Cluster Integration UI Tests Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 76d50fd into redhat-developer:main Oct 10, 2024
20 of 21 checks passed
@adietish adietish deleted the issue-909 branch October 12, 2024 00:18
sbouchet pushed a commit to sbouchet/intellij-openshift-connector that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reference of CRC and CDK from readme
2 participants